Fix use of identity/group endpoint to edit group by name #10812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use the second name lookup as the object to update.
mgritter
changed the title
swayne275
approved these changes
Jan 29, 2021
mgritter
pushed a commit
that referenced
this pull request
Jan 29, 2021
* Updates identity/group to allow updating a group by name (#10223) * Now that lookup by name is outside handleGroupUpdateCommon, do not use the second name lookup as the object to update. * Added changelog. Co-authored-by: dr-db <[email protected]>
mgritter
pushed a commit
that referenced
this pull request
Feb 1, 2021
…0813) * Updates identity/group to allow updating a group by name (#10223) * Now that lookup by name is outside handleGroupUpdateCommon, do not use the second name lookup as the object to update. * Added changelog. Co-authored-by: dr-db <[email protected]>
|
Looked at this post merge, and it looked great! |
|
This PR breaks the API used to discover group_id, also the guides for OIDC / Group Auth no longer work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.