Track barrier encryptions and rotate when an operation threshold or time limit is reached. #10774
+602
−171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). vault-storybook – ./ui🔍 Inspect: https://vercel.com/hashicorp/vault-storybook/kb61e5yrg [Deployment for 9779f47 canceled] |
HridoyRoy
suggested changes
Jan 28, 2021
…n_tracking # Conflicts: # internalshared/configutil/barrier.go
…mes up in replicated settings
|
Just a note to review this on the ENT branch. This will be updated with the OSS portions after review feedback/change iteration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One note on the design here: Checking when to rotate is done as encryptions
happen, to avoid needing a goroutine whose lifecycle we'd need to manage.
But as a result, this requires the AESGCMBarrier have access to the random
generator. I did this via a factory pattern, but it's in contrast to the
existing SecurityBarrier interface which passes in the random reader to all
calls that need it.