No 'v' in version HTML anchor #10491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The footer version output links to https://github.com/hashicorp/vault/blob/master/CHANGELOG.md#v160 (in Version 1.6.0) but you reach the anchor with https://github.com/hashicorp/vault/blob/master/CHANGELOG.md#160 (without 'v' before the version number)
|
|
|
Hi @Kloppi313 thanks for catching this and tackling it! Would you please fix the related test ( |
|
Hi @chelshaw, I guess the changelog file has to be named after the pull request number. |
chelshaw
approved these changes
Dec 8, 2020
chelshaw
added a commit
that referenced
this pull request
Dec 11, 2020
* No 'v' in version HTML anchor The footer version output links to https://github.com/hashicorp/vault/blob/master/CHANGELOG.md#v160 (in Version 1.6.0) but you reach the anchor with https://github.com/hashicorp/vault/blob/master/CHANGELOG.md#160 (without 'v' before the version number) * Removed 'v' from URL version anchor * Create 10491.txt Co-authored-by: Chelsea Shaw <[email protected]>
chelshaw
added a commit
that referenced
this pull request
Dec 14, 2020
* No 'v' in version HTML anchor The footer version output links to https://github.com/hashicorp/vault/blob/master/CHANGELOG.md#v160 (in Version 1.6.0) but you reach the anchor with https://github.com/hashicorp/vault/blob/master/CHANGELOG.md#160 (without 'v' before the version number) * Removed 'v' from URL version anchor * Create 10491.txt Co-authored-by: Chelsea Shaw <[email protected]> Co-authored-by: Kloppi313 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The footer version output links to https://github.com/hashicorp/vault/blob/master/CHANGELOG.md#v160 (in Version 1.6.0) but you reach the anchor with https://github.com/hashicorp/vault/blob/master/CHANGELOG.md#160 (without 'v' before the version number)