fix: always close db plugin connection

builtin/logical/database/path_rotate_credentials.go

@@ -76,6 +76,16 @@ func (b *databaseBackend) pathRotateCredentialsUpdate() framework.OperationFunc
 			return nil, err
 		}
 
+		defer func() {
+			// Close the plugin
+			db.closed = true
+			if err := db.Database.Close(); err != nil {
+				b.Logger().Error("error closing the database plugin connection", "err", err)
+			}
+			// Even on error, still remove the connection
+			delete(b.connections, name)
+		}()
+
 		// Take out the backend lock since we are swapping out the connection
 		b.Lock()
 		defer b.Unlock()
@@ -135,14 +145,6 @@ func (b *databaseBackend) pathRotateCredentialsUpdate() framework.OperationFunc
 			b.Logger().Warn("unable to delete WAL", "error", err, "WAL ID", walID)
 		}
 
-		// Close the plugin
-		db.closed = true
-		if err := db.Database.Close(); err != nil {
-			b.Logger().Error("error closing the database plugin connection", "err", err)
-		}
-		// Even on error, still remove the connection
-		delete(b.connections, name)
-
 		return nil, nil
 	}
 }