Add support for setting an Alias' name from the k8s namespace and serviceaccount #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvn
reviewed
Sep 3, 2021
benashz
changed the title
calvn
reviewed
Sep 3, 2021
calvn
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is a continuation of #103. Which added a new role configuration to store the
Alias.Namein the form ofnamespace/serviceaccount. Prior to this change theAlias.Namewould always be derived from the service account's tokenuid.Design of Change
Add a new
roles configurationalias_name_sourceto allow for setting one of the following naming formats:<token.uid>e.g.53f8253e-6df4-4be7-adae-f566c524c02c(remains the default)<namespace>/<serviceaccount>e.g.kube-system/corednsRelated Issues/Pull Requests
[ ] PR #103
Contributor Checklist
[ ] Add relevant docs to upstream Vault repository, or sufficient reasoning why docs won’t be added yet
My Docs PR Link
Example
[ ] Add output for any tests not ran in CI to the PR description (e.g., acceptance tests)
[X] Backwards compatible