enable logging from operator-lib #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses a logging type from consul to convert from hclog to logr's LogSink type. This also turned up a missing CluterRole permission for getting Nodes from k8s.
tomhjp
approved these changes
Mar 18, 2024
@tomhjp It's used to check for the case where the leader is stuck on a notReady k8s Node as I understand it: https://github.com/operator-framework/operator-lib/blob/b51f67c33ce55e3a148187047f7de70dd4f87d9d/leader/leader.go#L189-L196 So in general it was working for us, but would have trouble with that specific case. |
|
Awesome, thanks for the context - that's a great bit of extra resilience to have 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a logging type from consul to wrap an hclog logger in logr's LogSink type. This also turned up a missing ClusterRole permission for getting Nodes from k8s.
Fixes #605
ClusterRole permissions also added to the chart in hashicorp/vault-helm#1005
Related to hashicorp/vault-helm#980 and hashicorp/vault-helm#725
Log samples: