-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set authConfig before parsing annotations #457
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Left a couple comments, and it would be good to get some unit tests for this specific behavior.
Thanks for the review! I added a unit test case for setting Confirmed that it fails prior to my changes and passes with these changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the test!
Summary
Set
authConfig
from annotations after setting it from agent attributes, so that the annotations take precedence.Fixes
#456