Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to configure default vault namespace on the agent config #345

Merged
merged 3 commits into from
Jun 24, 2022

Conversation

flaviolemos78
Copy link
Contributor

@flaviolemos78 flaviolemos78 commented May 17, 2022

At the moment the only option to configure vault enterprise namespace is through the annotation vault.hashicorp.com/namespace at Pod level.
This presents some autonomy challenges for cluster/vault administrators. Example:

  • When migrating to Vault enterprise namespaces, administrators aren't able to seamless change the injector vault until the last "workload" add the namespace annotation....

This PR adds the ability to define a default vault namespace on the agent config. If the vault namespace isn't defined at Pod, then the configured vault namespace will be used, otherwise the Pod annotation value is used

@flaviolemos78 flaviolemos78 force-pushed the feat/default-vault-namespace branch from 85c3ad3 to 166cf13 Compare May 17, 2022 09:02
@flaviolemos78 flaviolemos78 force-pushed the feat/default-vault-namespace branch from 166cf13 to 400da09 Compare May 27, 2022 10:51
Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is a nice addition, and tested great for me.

@tvoran tvoran merged commit 74b1a3b into hashicorp:main Jun 24, 2022
@flaviolemos78
Copy link
Contributor Author

Hi @tvoran, do you know when will be the next release with this?

@bradfordwagner
Copy link

@flaviolemos78 - I'll follow this up with a MR against the helm chart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants