VAULT-2230 Only update webhooks CA bundle when needed #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvoran
reviewed
Apr 22, 2022
|
Thanks for the suggestions. This is ready for review again. I've switched to using an informer. |
tvoran
approved these changes
Apr 25, 2022
calvn
reviewed
Apr 26, 2022
swenson
force-pushed
the
VAULT-2230-patch-cabundle-on-change
branch
from
8033400 to
e3c5f24
Compare
|
@calvn let me know if you want to take another look |
calvn
approved these changes
Apr 28, 2022
added 8 commits
April 28, 2022 14:40
Instead of every second. Specifically, we now only update the webhooks bundle if: * we have generated a certificate and the CA bundle does not match the current webhook CA bundle; this will also happen if a new leader is elected, or * the webhook itself was changed (e.g., by a helm upgrade), checked by `Watch`ing the webhooks. In any case, will only send the `Patch` if the CA bundle on the webhook no longer matches our own CA bundle. This was tested by performing a `helm upgrade` with a webhook change and verifying that the webhook change was noticed and the CA bundle was patched, and also by setting the certificate lifetimes very low and making sure that the CA bundle was *not* patched (since the CA did not change when the certificate was regenerated). Fixes #332.
Also use the cache attached to it instead of querying the API ourselves.
* Use exponential backoff * Also simplify retry immediate logic * Remove namespace from mutating webhooks
swenson
force-pushed
the
VAULT-2230-patch-cabundle-on-change
branch
from
e3c5f24 to
d484cfa
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of every second. Specifically, we now only update the webhooks
bundle if:
current webhook CA bundle; this will also happen if a new leader is
elected, or
Watching the webhooks.In any case, will only send the
Patchif the CA bundle on thewebhook no longer matches our own CA bundle.
This was tested by performing a
helm upgradewith a webhook change andverifying that the webhook change was noticed and the CA bundle was
patched, and also by setting the certificate lifetimes very low and
making sure that the CA bundle was not patched (since the CA did not
change when the certificate was regenerated).
Fixes #332.