add share-process-namespace annotation #334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolffberg
force-pushed
the
share-process-namespace
branch
from
12055c3 to
06af380
Compare
|
@jasonodonnell @tvoran |
|
I believe this can now be accomplished using the new |
|
Oh, nevermind, the JSON patch is on the container, but |
swenson
reviewed
Dec 5, 2022
|
@wolffberg thanks for your contribution. If you have some spare cycles to resolve the conflicts we can merge your PR. If not then we'd be happy to take it over. Thanks! |
|
Going to take this PR over. |
|
Moved to #408 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many Helm Charts do not include an option to add the
shareProcessNamespaceswitch to deployments.Sharing the process namespace is needed to restart the pod on secret rotation as discussed in #196.
This PR will enable adding the switch through annotations using the mutating webhook as discussed in kubernetes-sigs/external-dns#2715.