Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Golang program started in a container, the P (from Golang GMP model) will be set to the number of CPU cores of host instead of container's CPU limit (cgroups).
Assuming vault-agent sidecar is deployed on a 16core64g machine, the P of vault-agent will be set to the number of CPU cores by default, which is 16, and the available CPU of the vault-agent is 500m (helm chart default setting), which will cause the CPU to be used too high constantly. Solved by explicitly setting
GOMAXPROCS
to 1.Therefore, add annotation
vault.hashicorp.com/go-max-procs
to support configuring P's number accordingly.