Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add annotation for rendered file permission #277

Merged
merged 4 commits into from
Aug 13, 2021
Merged

Add annotation for rendered file permission #277

merged 4 commits into from
Aug 13, 2021

Conversation

lawliet89
Copy link
Contributor

@lawliet89 lawliet89 commented Aug 5, 2021 •
edited
Loading

Add a new annotation to allow the user to set the rendered file permission.

Fixes #136

$ make test
go test -race ./...
?       github.com/hashicorp/vault-k8s  [no test files]
ok      github.com/hashicorp/vault-k8s/agent-inject     (cached)
ok      github.com/hashicorp/vault-k8s/agent-inject/agent       0.059s
ok      github.com/hashicorp/vault-k8s/helper/cert      (cached)
?       github.com/hashicorp/vault-k8s/helper/flags     [no test files]
?       github.com/hashicorp/vault-k8s/leader   [no test files]
ok      github.com/hashicorp/vault-k8s/subcommand/injector      (cached)
?       github.com/hashicorp/vault-k8s/subcommand/version       [no test files]
?       github.com/hashicorp/vault-k8s/version  [no test files]

@lawliet89 lawliet89 changed the title Add configuration for rendered file permission Add annotation for rendered file permission Aug 5, 2021
@tvoran tvoran self-requested a review August 11, 2021 17:58
tvoran
tvoran reviewed Aug 11, 2021
View reviewed changes
Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great for me. Just a couple suggestions.

agent-inject/agent/annotations.go Outdated Show resolved Hide resolved
agent-inject/agent/annotations_test.go Outdated Show resolved Hide resolved
agent-inject/agent/annotations_test.go Outdated Show resolved Hide resolved
tvoran
tvoran approved these changes Aug 13, 2021
View reviewed changes
Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tvoran tvoran merged commit 6b1dbe2 into hashicorp:master Aug 13, 2021
@tvoran tvoran mentioned this pull request Aug 13, 2021
Closed
@lawliet89 lawliet89 deleted the perms branch August 13, 2021 08:08
@lawliet89 lawliet89 mentioned this pull request Aug 19, 2021
Closed
lawliet89 added a commit to lawliet89/vault that referenced this pull request Aug 19, 2021
@lawliet89
Document K8S file permission annotation
b08f5b6 
Document feature implemented in
hashicorp/vault-k8s#277 and released in
`vault-k8s` v0.12.0
RemcoBuddelmeijer pushed a commit to RemcoBuddelmeijer/vault-k8s that referenced this pull request Feb 22, 2022
@lawliet89 @tvoran
Add annotation for rendered file permission (hashicorp#277)
1ee08f0 
Co-authored-by: Theron Voran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvoran tvoran tvoran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lack of control of file permissions of rendered secrets
2 participants
@lawliet89 @tvoran