agent-inject: add exit_on_retry_failure flag and annotation #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvoran
approved these changes
Jun 25, 2021
There was a problem hiding this comment.
This tested good for me 👍
Only thing I'd suggest is adding a test for the generated config in https://github.com/hashicorp/vault-k8s/blob/87fd9ba1348ef1a6d4d649007885cba3319d5c75/agent-inject/agent/config_test.go
RemcoBuddelmeijer
pushed a commit
to RemcoBuddelmeijer/vault-k8s
that referenced
this pull request
Feb 22, 2022
…p#267) * agent-inject: add template_config.exit_on_retry_failure flag and annotation * agent-inject: shorten annotation name for exit-on-retry-failure * agent-inject: add config test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for setting Vault Agent's new
template_config.exit_on_retry_failureintroduced in hashicorp/vault#11775.A new flag and environment variable,
AGENT_INJECT_TEMPLATE_CONFIG_EXIT_ON_RETRY_FAILURE, is added to allow this value to be toggled globally. There's also a new annotation,agent-template-config-exit-on-retry-failure, on agent-inject to allow for pods to override this value. The default value for this istruesince we don't want pods being stuck during deployments if any of Agent's templates fail to render.