Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a name to the service port #262

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Conversation

LS80
Copy link
Contributor

@LS80 LS80 commented Jun 1, 2021

The prometheus operator requires a named service port. This also matches the service created by the vault helm chart.

The prometheus operator requires a named service port. This also matches
The service created by the vault helm chart.
@hashicorp-cla
Copy link

hashicorp-cla commented Jun 1, 2021

CLA assistant check
All committers have signed the CLA.

@LS80
Copy link
Contributor Author

LS80 commented Apr 22, 2022

@tvoran Could you review this tiny change?

@swenson swenson self-requested a review April 28, 2022 17:54
Copy link

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

@swenson swenson merged commit 15f3572 into hashicorp:main Apr 28, 2022
@LS80 LS80 deleted the add-service-port-name branch April 29, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants