Use a file sink for agent-inject-token #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of auth/token/lookup-self, which doesn't work when persistent agent caching is enabled.
calvn
approved these changes
Apr 21, 2021
This was
linked to
issues
Apr 22, 2021
This was referenced Apr 22, 2021
RemcoBuddelmeijer
pushed a commit
to RemcoBuddelmeijer/vault-k8s
that referenced
this pull request
Feb 22, 2022
Instead of auth/token/lookup-self, which doesn't work when persistent agent caching is enabled.
tvoran
added a commit
that referenced
this pull request
Feb 24, 2022
tvoran
added a commit
that referenced
this pull request
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since injecting the token from
auth/token/lookup-selfas a secret doesn't work when persistent caching is enabled, this PR uses a file sink instead to make the auto-auth token available to the app container at/vault/secrets/token. This also means ACLs are no longer required forauth/token/lookup-self. It also gets around the warning noted in #195 and the newline issue in #207.Fixes #237, #195, #207.