Add flag and annotation to override default template #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvoran
approved these changes
Apr 3, 2021
RemcoBuddelmeijer
pushed a commit
to RemcoBuddelmeijer/vault-k8s
that referenced
this pull request
Feb 22, 2022
* Add flag/annotation override for default template * Update deployment * Fix test * Clean up test structs * Update per review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current default template (a map) is not easy to consume by applications due to the weird formatting. I've added a global default via flag/env (
AGENT_INJECT_DEFAULT_TEMPLATE), as well as an annotation (agent-inject-default-template) to override this to either bemaporjson. I'm keeping the default asmapso this is backwards compatible in case any application is actually using that style of value.Once merged we can expose the global in Vault Helm.
Fixes #116.