add xc-prod-image for cross compiling vault-k8s in release pipeline #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonodonnell
approved these changes
Feb 17, 2021
sarahethompson
approved these changes
Feb 22, 2021
RemcoBuddelmeijer
pushed a commit
to RemcoBuddelmeijer/vault-k8s
that referenced
this pull request
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new Make target,
xc-prod-imagewhich will usedocker buildxto cross compile the vault-k8s image across 4 different architectures (and optionally publish withXC_PUBLISH=--push). This target is used in the release pipeline but could also be called locally if desired and the host machine has all the necessary packages for usingdocker buildx(normal Docker for Mac should just work as long asDOCKER_CLI_EXPERIMENTAL=enabled). The release pipeline changes are found in https://github.com/hashicorp/vault-k8s-release/pull/4.This does require us to start cross compiling binaries for the 4 different versions though.