Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sidecar env tests #219

Merged
merged 2 commits into from
Feb 2, 2021
Merged

Fix sidecar env tests #219

merged 2 commits into from
Feb 2, 2021

Conversation

jasonodonnell
Copy link
Contributor

Some tests were broken with #200 so this PR fixes those to account for the new env VAULT_LOG_FORMAT.

@jasonodonnell jasonodonnell added the bug Something isn't working label Feb 2, 2021
Copy link
Contributor

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than go fmt

@jasonodonnell jasonodonnell merged commit 78bdc57 into master Feb 2, 2021
@jasonodonnell jasonodonnell deleted the envs branch February 2, 2021 17:32
RemcoBuddelmeijer pushed a commit to RemcoBuddelmeijer/vault-k8s that referenced this pull request Feb 22, 2022
* Fix sidecar env tests

* make fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants