Add support for injecting HTTPS_PROXY env var in agent containers #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I managed to validate this change in a local Kubernetes cluster. I validated these flows:
Please let me know if you want me to perform any other manual tests. |
|
One question I have is to whether it makes sense to inject the same value in the Since the recommended Vault server setup is to enable TLS, maybe this PR is good enough as is, but it may not work for development/test Vault clusters without TLS enabled, as requests are sent to Vault in plain HTTP. Let me know what you think. |
|
All looks good here @danielfm, do you mind resolving the conflicts? |
This struct seems to be used for defining the Vault agent configuration file[1], but since it doesn't have a specific flag for setting up a proxy address, this field is useless. [1] https://www.vaultproject.io/docs/agent
|
@jasonodonnell done. |
RemcoBuddelmeijer
pushed a commit
to RemcoBuddelmeijer/vault-k8s
that referenced
this pull request
Feb 22, 2022
…shicorp#211) * Add support for injecting HTTPS_PROXY env var in agent containers * Remove unnecessary field This struct seems to be used for defining the Vault agent configuration file[1], but since it doesn't have a specific flag for setting up a proxy address, this field is useless. [1] https://www.vaultproject.io/docs/agent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR necessary, what does it do?
This PR aims to add to the injector the ability of setting the
HTTPS_PROXYenvironment variable in the init/sidecar containers in order to allow requests to Vault to be made via a proxy.References:
Fixes: #205
Notes:
If the reviewers feel there are tests missing, please let me know! I may have missed something.
I'll try to run this version of the injector in a test cluster to validate the workflow, but in the mean time, feel free to comment.