-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for Ingress PathType #634
Conversation
Signed-off-by: Tim Collins <[email protected]>
Signed-off-by: Tim Collins <[email protected]>
Thanks for the quick fix! Would you mind adding tests for this in |
Signed-off-by: Tim Collins <[email protected]>
Signed-off-by: Tim Collins <[email protected]>
First time using bats (or frankly, writing unit tests!). Hopefully what I've done is sufficient @tvoran? |
Signed-off-by: Tim Collins <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just a few minor suggestions.
Co-authored-by: Ben Ash <[email protected]>
Co-authored-by: Ben Ash <[email protected]>
Co-authored-by: Ben Ash <[email protected]>
Signed-off-by: Tim Collins <[email protected]>
All changes implemented @benashz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Tim Collins [email protected]
Fixes: #633