fix(csi-ds): mountpoint-dir same mountpath in pod #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Toni Tauro <[email protected]>
|
Pinging @benashz This is something we didn't test :D Sorry |
benashz
reviewed
Oct 19, 2021
| @@ -44,7 +44,7 @@ spec: | |||
| - name: providervol | |||
| mountPath: "/provider" | |||
| - name: mountpoint-dir | |||
| mountPath: /var/lib/kubelet/pods | |||
| mountPath: {{ .Values.csi.daemonSet.kubeletRootDir }}/pods | |||
There was a problem hiding this comment.
This seems fine as long as the csi-provider's kubeletRootDir is configured the same. I don't see the need to ever change the default value however, since this would entail deploying the worker nodes in a nonstandard way.
Perhaps when/if we add support for Windows to the CSI the we could turn this into a helper function.
There was a problem hiding this comment.
Thank you @benashz
Of course I agree with you, there should never be the need to change the default dir for /var/lib/kubelet
We encountered Nutanix Karbon doing this and putting /var/lib/kubelet under /var/nutanix/var/lib/kubelet, this is why we are in need of this change.
benashz
approved these changes
Oct 19, 2021
benashz
added a commit
that referenced
this pull request
Oct 21, 2021
benashz
added a commit
that referenced
this pull request
Oct 21, 2021
illegalnumbers
pushed a commit
to streamnative/vault-helm
that referenced
this pull request
Mar 17, 2022
* fix(csi-ds): mountpoint-dir same mountpath in pod Signed-off-by: Toni Tauro <[email protected]> * Update Chart.yaml Co-authored-by: Ben Ash <[email protected]>
illegalnumbers
pushed a commit
to streamnative/vault-helm
that referenced
this pull request
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the mountpoint-dir overwrite introduced in #603
The mountppath inside the pod should be the same as on the node, or you'll end up with a
no such file or directoryerrorSigned-off-by: Toni Tauro [email protected]