-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] rough changes that fix vsphere vm's on master #6547
Conversation
cc: @chrislovecnm. You seem to be commenting on all of the vSphere issues / PR's surrounding getting master to work. Thought you might find this useful as a starting point for a more robust solution. |
Hi @knuckolls, |
@knuckolls thanks for the work. So we believe that there is a way to do this in the API - I am @ the airport so I cannot go into details. I think we may have a better way to do this ;) Again thanks for your work. We appreciate you committing and if you are interested in helping more, we definitely can use you help. Let me know if you want to coordinate more. |
@knuckolls does #6377 address these problems? If so please close out this PR. BTW thanks for contributing, if you have an opportunity to help out, we have stuff to do :) |
Hi @knuckolls / @chrislovecnm Any thoughts on the status of this PR is this still needed or has #6377 got this covered? Paul |
Hello! I'm going through |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
I'm not sure if this should be merged in it's current form but I wanted to put this out there so people could see what I had to do to get vSphere vms working today.
Currently master pulls the network information too soon thus if anything wants to subsequently use the IP of the instance it fails. I believe this is documented in #6174 and this PR is a really rough fix for the problem. I solved this by adding in a loop that spins until the network information is not null. This probably needs a circuit breaker after some amount of time but it's effective.
I also am not sure if this would work at all with DHCP. It does work when all the addressing information is passed in statically. Furthermore, this fix (#6522) for pulling in the gateway routing information flat out didn't work for me (and I debugged it for hours) so I statically set the gateway based upon what's passed in from the configuration.
Hopefully someone finds this helpful. I'm going to use it as a stopgap for my purposes.