command/views: Remove baseState argument from plan-rendering views #28656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In practice the current implementation isn't actually using this, and if we need access to states in future we can access them in either the plan.PriorState or plan.PrevRunState fields, depending on which stage we want a state snapshot of.
apparentlymart
added
enhancement
cli
0.15-backport
alisdair
approved these changes
May 10, 2021
apparentlymart
removed
the
0.15-backport
|
Backported to v0.15 as fd8316e |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In practice the current implementation isn't actually using this, and if we need access to states in future we can access them in either the
plan.PriorStateorplan.PrevRunStatefields, depending on which stage we want a state snapshot of.(Technically these two plan fields aren't reliably available until we also merge #28653, but that's moot here because the current view code doesn't access either of them anyway. #28634 will eventually make use of this to produce the "Objects have changed outside of Terraform" bit, though.)