Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump go-getter to 1.5.2 #28189

Merged
merged 1 commit into from
Apr 5, 2021
Merged

bump go-getter to 1.5.2 #28189

merged 1 commit into from
Apr 5, 2021

Conversation

mwhooker
Copy link
Contributor

after a fresh terraform checkout, I got the following error trying to build:

verifying github.com/hashicorp/[email protected]: checksum mismatch
	downloaded: h1:LZ49OxqBBtdKJymlpX7oTyqGBQRg4xxQDyPW4hzoZqM=
	go.sum:     h1:lM9sM02nvEApQGFgkXxWbhfqtyN+AyhQmi+MaMdBDOI=

SECURITY ERROR
This download does NOT match an earlier download recorded in go.sum.
The bits may have been replaced on the origin server, or an attacker may
have intercepted the download attempt.

For more information, see 'go help module-auth'.

After some research, it appears that two versions of go-getter v1.5.1 were released (see related discussion in hashicorp/nomad#9349 (comment)).

Bumping the go-getter version gets around this issue.

The changes in go-getter are minimal and appear to mostly be about adding support for .zst and .zstd files. See diff https://github.com/hashicorp/go-getter/compare/v1.5.1..v1.5.2

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #28189 (9f8dc26) into main (550de86) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted Files Coverage Δ
terraform/node_resource_plan.go 96.11% <0.00%> (-1.95%) ⬇️

Copy link
Contributor

@mildwonkey mildwonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @mwhooker (& I appreciate the link to the diff, ty)

@mildwonkey mildwonkey merged commit 49c984f into main Apr 5, 2021
@ghost
Copy link

ghost commented May 6, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators May 6, 2021
@xiehan xiehan deleted the go-get1.5.2 branch July 22, 2024 12:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants