Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capture existing config in new config file/format for hashibot #21765

Merged
merged 3 commits into from
Jun 20, 2019

Conversation

appilon
Copy link
Contributor

@appilon appilon commented Jun 18, 2019

No description provided.

@hashicorp-cla
Copy link

hashicorp-cla commented Jun 18, 2019

CLA assistant check
All committers have signed the CLA.

@appilon appilon changed the title [DO NOT MERGE] capture existing config in new config file/format for hashibot capture existing config in new config file/format for hashibot Jun 19, 2019
@appilon appilon requested a review from a team June 19, 2019 22:19
"provider/vcloud" = "provider/vcd"
}
issue_header = <<-EOF
_This issue was originally opened by ${var.user} as ${var.repository}#${var.issue_number}. It was migrated here as a result of the [provider split](https://www.hashicorp.com/blog/upcoming-provider-changes-in-terraform-0-10/). The original body of the issue is below._
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressing this in a separate change is fine if you'd rather keep this focused on behavior-parity, but I think "Upcoming Provider Changes in 0.10" is old enough now that we should probably find a different wording for this that talks about it more as "just the way things are" rather than as a change to how things used to be.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah parity is the current goal but feel free to customize away in follow ups with the power of HCL2 and hashibot 😄

@appilon appilon merged commit 2055074 into master Jun 20, 2019
@appilon appilon deleted the appilon/hashibot branch June 20, 2019 00:27
@ghost
Copy link

ghost commented Jul 25, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants