-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/azurerm: Add example of VNET to VNET Peering #14338
provider/azurerm: Add example of VNET to VNET Peering #14338
Conversation
…t script, added mac specific deployment for local testing
…hmagnitude/terraform into topic-101-vm-from-user-image
* initial commit - 101-vm-from-user-image * added tfvars and info for README * added CI config; added sane defaults for variables; updated deployment script, added mac specific deployment for local testing * prep for PR
azure-vm-from-user-image
* initial commit * need to change lb_rule & nic * deploys locally * updated README * updated travis and deploy scripts for Hari's repo * renamed deploy script * clean up * prep for PR * updated readme * fixing conflict in .travis.yml
…topic-201-vnet-to-vnet-peering
…arijayms/terraform into topic-201-vnet-to-vnet-peering
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR - I've reviewed and left some comments inline, but it otherwise looks good :)
Thanks!
# client_id = "REPLACE-WITH-YOUR-CLIENT-ID" | ||
# client_secret = "REPLACE-WITH-YOUR-CLIENT-SECRET" | ||
# tenant_id = "REPLACE-WITH-YOUR-TENANT-ID" | ||
# } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this file can be removed since it's integrated into the main.tf
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's gone now. :)
# hostname = "myvm" | ||
# dns_name = "mydnsname" | ||
# location = "southcentralus" | ||
# admin_password = "T3rr@f0rmP@ssword" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we can remove this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's gone now.
## outputs.tf | ||
This data is outputted when `terraform apply` is called, and can be queried using the `terraform output` command. | ||
|
||
## provider.tf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this file can be removed since the contents are in the main.tf
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the README; let me know what you think.
LGTM - thanks for the followup work here :) |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
CI:
This example provisions and deploys the following resources into an Azure subscription:
CI process: