tf 0.5.0 :: Resource "template_file" instance :: "diffs didn't match during apply" bug

[nuallain]

I'm being told by Terraform that I should report a bug. Details below.

$ terraform --version
Terraform v0.5.0

$ consul --version
Consul v0.5.0
Consul Protocol: 2 (Understands back to: 1)

$ terraform apply
template_file.deployment: Creating...
  filename:                      "" => "deployment.json"
  rendered:                      "" => "<computed>"
  vars.#:                        "0" => "2"
  vars.application_name:         "" => "bootstrap"
  vars.deployment_configuration: "" => "default"
template_file.deployment: Creation complete
consul_keys.application_service: Creating...
  datacenter:            "" => "<computed>"
  key.#:                 "" => "1"
  key.449824328.default: "" => ""
  key.449824328.delete:  "" => "0"
  key.449824328.name:    "" => "deployment"
  key.449824328.path:    "" => "node/deployment"
  key.449824328.value:   "" => "{\n    \"application_name\": \"bootstrap\",\n    \"deployment_configuration\": \"default\"\n}\n"
  var.#:                 "" => "<computed>"
consul_keys.application_service: Creation complete

Apply complete! Resources: 2 added, 0 changed, 0 destroyed.

The state of your infrastructure has been saved to the path
below. This state is required to modify and destroy your
infrastructure, so keep it safe. To inspect the complete state
use the `terraform show` command.

State path: terraform.tfstate

$ terraform apply
template_file.deployment: Refreshing state... (ID: 8cca96a9cc6f7174f1a2)
consul_keys.application_service: Refreshing state... (ID: consul)
template_file.deployment: Creating...
  filename:                      "" => "deployment.json"
  rendered:                      "" => "<computed>"
  vars.#:                        "0" => "2"
  vars.application_name:         "" => "bootstrap"
  vars.deployment_configuration: "" => "default"
template_file.deployment: Creation complete
Error applying plan:

1 error(s) occurred:

* 1 error(s) occurred:

* consul_keys.application_service: diffs didn't match during apply. This is a bug with Terraform and should be reported.

Terraform does not automatically rollback in the face of errors.
Instead, your Terraform state file has been partially updated with
any resources that successfully completed. Please address the error
above and apply again to incrementally change your infrastructure.

$cat application_service.tf 
variable "application_name" {
    default = "bootstrap"
}

variable "deployment_configuration" {
    default = "default"
}

# add node's configuration to consul
resource "template_file" "deployment" {
    filename = "deployment.json"
    vars {
       application_name = "${var.application_name}"
       deployment_configuration = "${var.deployment_configuration}"
    }
}

resource "consul_keys" "application_service" {

    key {
        name = "deployment"
        path = "node/deployment"
        value = "${template_file.deployment.rendered}"
    }
}

[mitchellh]

Can you please gist your debug log? Please cmd-f it for secrets at first. And please use gist, since it'll be quite large.

[nuallain]

Here you go. https://gist.github.com/nuallain/c197c5515718132d948b

[phinze]

Thanks for this. Looks like an empty diff on the apply side.

consul_keys.application_service: diffs didn't match
consul_keys.application_service: reason: attribute mismatch: key.~449824328.delete
diff one: *terraform.InstanceDiff{Attributes:map[string]*terraform.ResourceAttrDiff{
  "key.~449824328.default":*terraform.ResourceAttrDiff{Old:"", New:"", NewComputed:false, NewRemoved:true, NewExtra:interface {}(nil), RequiresNew:false, Type:0x0},
  "key.~449824328.delete":*terraform.ResourceAttrDiff{Old:"0", New:"0", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Type:0x0},
  "key.~449824328.name":*terraform.ResourceAttrDiff{Old:"deployment", New:"deployment", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Type:0x0},
  "key.~449824328.path":*terraform.ResourceAttrDiff{Old:"node/deployment", New:"node/deployment", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Type:0x0},
  "key.~449824328.value":*terraform.ResourceAttrDiff{Old:"{\n    \"application_name\": \"bootstrap\",\n    \"deployment_configuration\": \"default\"\n}\n", New:"${template_file.deployment.rendered}", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Type:0x0}}, Destroy:false, DestroyTainted:false}

diff two: *terraform.InstanceDiff{Attributes:map[string]*terraform.ResourceAttrDiff(nil), Destroy:false, DestroyTainted:false}

I'll continue to dig in.

[phinze]

Okay I think #1879 might be masking the issue here. Going to go and solve that first.

[mschuett]

Just FYI, I encountered the same problem with aws_iam_user_policy.

[phinze]

I've reproduced the same diff mismatch without the template_file by just having consul_keys depend on a computed attribute.

Config: https://github.com/phinze/terraform-issues/tree/master/1866-template-diff-mismatch

Diff mismatch resulting from changing var.planet and applying:

2015/05/09 15:48:42 [ERROR] consul_keys.hello: diffs didn't match
2015/05/09 15:48:42 [ERROR] consul_keys.hello: reason: attribute mismatch: key.~1809182598.delete
2015/05/09 15:48:42 [ERROR] consul_keys.hello: diff one: *terraform.InstanceDiff{Attributes:map[string]*terraform.ResourceAttrDiff{"key.~1809182598.default":*terraform.ResourceAttrDiff{Old:"", New:"", NewComputed:false, NewRemoved:true, NewExtra:interface {}(nil), RequiresNew:false, Type:0x0}, "key.~1809182598.delet
e":*terraform.ResourceAttrDiff{Old:"0", New:"0", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Type:0x0}, "key.~1809182598.name":*terraform.ResourceAttrDiff{Old:"hello", New:"hello", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Type:0x0}, "
key.~1809182598.path":*terraform.ResourceAttrDiff{Old:"world", New:"world", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Type:0x0}, "key.~1809182598.value":*terraform.ResourceAttrDiff{Old:"Hello earth!\n", New:"${aws_instance.public.tags.Hello}", NewComputed:false, NewRemoved:f
alse, NewExtra:interface {}(nil), RequiresNew:false, Type:0x0}}, Destroy:false, DestroyTainted:false}
2015/05/09 15:48:42 [ERROR] consul_keys.hello: diff two: *terraform.InstanceDiff{Attributes:map[string]*terraform.ResourceAttrDiff(nil), Destroy:false, DestroyTainted:false}

Note the second diff is empty.

@mschuett can you toss up a bit of config demonstrating the problem you hit? I'd like to see if I can correlate this to something common between aws_iam_policy and consul_keys

[mschuett]

Here is a small example for aws_iam_policy with config file, ftstate file, and debug output: https://gist.github.com/mschuett/141fe2fd07c9e5643bd5

[nuallain]

FYI, we've got full encryption enabled for consul - gossip and authentication.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.