Allow tfe_organization_membership import by org name and user email

[JarrettSpiker]

Description

Allow tfe_organization_membership resource to also be imported by org-name/user-email

Presently, the resource can only be imported through its ID, which is not presented to the user in the TFE UI. This makes it very difficult to import.

Testing plan

1. Test that import by ID still works
2. Test that importing by org/email works
3. Test that importing by an invalid format errors
4. Test that importing a non existent org name or email errors

External links

• internal JIRA
• resource documentation

Output from acceptance tests

❯ TF_ACC=1 go test ./...  -run TestAccTFEOrganizationMembership -tags=integration -v
?       github.com/hashicorp/terraform-provider-tfe     [no test files]
=== RUN   TestAccTFEOrganizationMembershipDataSource_basic
--- PASS: TestAccTFEOrganizationMembershipDataSource_basic (17.87s)
=== RUN   TestAccTFEOrganizationMembershipDataSource_findByName
    data_source_organization_membership_test.go:47: Please set TFE_USER1 to run this test
--- SKIP: TestAccTFEOrganizationMembershipDataSource_findByName (0.36s)
=== RUN   TestAccTFEOrganizationMembershipDataSource_missingParams
--- PASS: TestAccTFEOrganizationMembershipDataSource_missingParams (4.41s)
=== RUN   TestAccTFEOrganizationMembership_basic
--- PASS: TestAccTFEOrganizationMembership_basic (6.66s)
=== RUN   TestAccTFEOrganizationMembershipImport_ByID
--- PASS: TestAccTFEOrganizationMembershipImport_ByID (6.94s)
=== RUN   TestAccTFEOrganizationMembershipImport_ByEmail
--- PASS: TestAccTFEOrganizationMembershipImport_ByEmail (7.05s)
=== RUN   TestAccTFEOrganizationMembershipImport_invalidImportId
--- PASS: TestAccTFEOrganizationMembershipImport_invalidImportId (7.72s)
PASS
ok      github.com/hashicorp/terraform-provider-tfe/tfe 51.182s


...

[sebasslash]

Panic ❗

Suggested change

	tfeClient := meta.(*tfe.Client)
	config := meta.(ConfiguredClient)
	// you can use the tfe client: config.Client.Workspaces.Blah()

This change was introduced in #762

[JarrettSpiker]

Fixed! Thanks for catching that

[brandonc]

This is great. Can you rebase the CHANGELOG?

[JarrettSpiker]

This is great. Can you rebase the CHANGELOG?

Absolutely! I will merge this once I get some local dev issues figured out and I can test out the rebase

[brandonc]

We are struggling with some upstream test infrastructure changes today. I'm going to merge this now and ensure the tests pass later on.