Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manage_run_tasks to Org. Team Access #486

Merged
merged 3 commits into from
May 17, 2022
Merged

Conversation

glennsarti
Copy link
Contributor

@glennsarti glennsarti commented May 5, 2022

Description

Run Tasks added a new Organizational access type called manage_run_tasks.
This commit updates the organization_access of Teams to include this new
access type.

Testing plan

Acceptance tests are updated in the PR

External links

Output from acceptance tests

N/A - Run as part of CI

@glennsarti glennsarti self-assigned this May 5, 2022
@glennsarti glennsarti requested review from brandonc and a team and removed request for brandonc May 5, 2022 06:36
@glennsarti glennsarti force-pushed the gs/add-runtask-org-access branch from 84b0853 to da04175 Compare May 6, 2022 03:24
@glennsarti glennsarti requested a review from cam-stitt May 6, 2022 04:04
Copy link
Member

@cam-stitt cam-stitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glennsarti
Copy link
Contributor Author

Would appreciate a tf-cli ✔ before I merge

Copy link
Contributor

@annawinkler annawinkler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this change! Could you please update the webpage documentation with this new access?

@glennsarti
Copy link
Contributor Author

Docs Update:

image

Run Tasks added a new Organizational access type called `manage_run_tasks`.
This commit updates the organization_access of Teams to include this new
access type.
@glennsarti glennsarti force-pushed the gs/add-runtask-org-access branch from 0cb8621 to d5ed4d3 Compare May 16, 2022 07:52
@glennsarti
Copy link
Contributor Author

Rebased as the go-tfe update was done outside of this PR

@glennsarti
Copy link
Contributor Author

@annawinkler Would appreciate a +1 before merge

Copy link
Contributor

@annawinkler annawinkler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Looks good - thanks!

@glennsarti glennsarti merged commit c43bdee into main May 17, 2022
@glennsarti glennsarti deleted the gs/add-runtask-org-access branch May 17, 2022 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants