Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add speculative_enabled argument to tfe_workspace #210

Merged
merged 3 commits into from
Sep 23, 2020
Merged

Add speculative_enabled argument to tfe_workspace #210

merged 3 commits into from
Sep 23, 2020

Conversation

jgiannuzzi
Copy link
Contributor

@jgiannuzzi jgiannuzzi commented Aug 27, 2020

Description

This change adds support for the speculative_enabled argument to tfe_workspace.

Fixes #211

Testing plan

The tests have been updated to test this in the same way that file_triggers_enabled is tested.
file_triggers_enabled also defaults to true during workspace creation and is thus quite comparable.

External links

Output from acceptance tests

$ TESTARGS="-run TestAccTFEWorkspace" make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccTFEWorkspace -timeout 15m
?   	github.com/terraform-providers/terraform-provider-tfe	[no test files]
=== RUN   TestAccTFEWorkspaceIDsDataSource_basic
--- PASS: TestAccTFEWorkspaceIDsDataSource_basic (10.96s)
=== RUN   TestAccTFEWorkspaceIDsDataSource_wildcard
--- PASS: TestAccTFEWorkspaceIDsDataSource_wildcard (10.31s)
=== RUN   TestAccTFEWorkspaceDataSource_basic
--- PASS: TestAccTFEWorkspaceDataSource_basic (8.54s)
=== RUN   TestAccTFEWorkspace_basic
--- PASS: TestAccTFEWorkspace_basic (6.75s)
=== RUN   TestAccTFEWorkspace_panic
--- PASS: TestAccTFEWorkspace_panic (7.31s)
=== RUN   TestAccTFEWorkspace_monorepo
--- PASS: TestAccTFEWorkspace_monorepo (7.28s)
=== RUN   TestAccTFEWorkspace_renamed
--- PASS: TestAccTFEWorkspace_renamed (9.51s)
=== RUN   TestAccTFEWorkspace_update
--- PASS: TestAccTFEWorkspace_update (10.76s)
=== RUN   TestAccTFEWorkspace_updateWorkingDirectory
--- PASS: TestAccTFEWorkspace_updateWorkingDirectory (15.61s)
=== RUN   TestAccTFEWorkspace_updateFileTriggers
--- PASS: TestAccTFEWorkspace_updateFileTriggers (11.14s)
=== RUN   TestAccTFEWorkspace_updateTriggerPrefixes
--- PASS: TestAccTFEWorkspace_updateTriggerPrefixes (11.02s)
=== RUN   TestAccTFEWorkspace_updateSpeculative
--- PASS: TestAccTFEWorkspace_updateSpeculative (11.02s)
=== RUN   TestAccTFEWorkspace_updateVCSRepo
    TestAccTFEWorkspace_updateVCSRepo: resource_tfe_workspace_test.go:372: Please set GITHUB_TOKEN to run this test
--- SKIP: TestAccTFEWorkspace_updateVCSRepo (0.54s)
=== RUN   TestAccTFEWorkspace_sshKey
--- PASS: TestAccTFEWorkspace_sshKey (16.25s)
=== RUN   TestAccTFEWorkspace_import
--- PASS: TestAccTFEWorkspace_import (7.26s)
PASS
ok  	github.com/terraform-providers/terraform-provider-tfe/tfe	144.541s
?   	github.com/terraform-providers/terraform-provider-tfe/version	[no test files]

@ghost ghost added size/L and removed size/XXL labels Sep 23, 2020
@jgiannuzzi jgiannuzzi marked this pull request as ready for review September 23, 2020 18:32
@jgiannuzzi
Copy link
Contributor Author

Hey @koikonom, I had to force push my commit to bump go-tfe to v0.10.2. I did the update on Linux so that the vendor dir would not dramatically change.

This PR is now ready for review! 😄

@koikonom
Copy link
Contributor

Yeah you had to force push because I pushed the same change myself :)

@koikonom koikonom merged commit c975590 into hashicorp:master Sep 23, 2020
@jgiannuzzi
Copy link
Contributor Author

Thanks for the merge, @koikonom!

@jgiannuzzi jgiannuzzi deleted the add-workspace-speculative-enabled branch September 23, 2020 18:47
@jgiannuzzi
Copy link
Contributor Author

Hey @koikonom, we would love to be able to use this new feature in an official build — could you please create a new release soon? Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add speculative_enabled argument to tfe_workspace
2 participants