chore: upgrade tfe_organization_default_settings to provider framework #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrombley
force-pushed
the
TF-24337-port-tfe-organization-default-settings-to-the-newer-provider-framework
branch
from
8154fae to
8569acf
Compare
uturunku1
reviewed
Mar 7, 2025
| }, | ||
|
|
||
| "default_execution_mode": { | ||
| Type: schema.TypeString, | ||
| "default_execution_mode": schema.StringAttribute{ |
There was a problem hiding this comment.
If you use default_execution_mode = "local" alongside default_agent_pool_id attribute, it causes the error Provider produced inconsistent result after apply. The documentation for default_agent_pool_id attribute is clear that it Requires default_execution_mode to be set to agent.
But I'm curious if there is a validator like conflictsWith or something else that we could use here to avoid that confusing error. If not, no big deal!
…ngs-to-the-newer-provider-framework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades the
tfe_organization_default_settingsresource to the provider framework.Testing plan