Added support for redis instance data source #6536
Conversation
ghost
requested a review
from 
|
Hey @MounirKaroudEV is this PR ready for review? If not, please tag me when it is. Thanks! |
|
Hi @slevenick the pr now is ready for review, can you please have a look? Thanks |
website/google.erb
Outdated
| @@ -46,23 +46,23 @@ | |||
| <li> | |||
| <a href="#">Resources</a> | |||
| <ul class="nav nav-auto-expand"> | |||
|
|
|||
There was a problem hiding this comment.
Can you revert the changes to this file? Looks like they are spacing changes and shouldn't matter
| func testAccRedisInstanceDatasourceConfig(suffix string) string { | ||
| return fmt.Sprintf(` | ||
| resource "google_redis_instance" "redis" { | ||
| name = "redis-test-%s" |
There was a problem hiding this comment.
tabs v spaces in this config, if you could just make them consistent one way or the other
|
Fixed all the space formatting issues 😄 |
|
Actually, would it be possible to have you make these changes against the Magic Modules repo here: https://github.com/GoogleCloudPlatform/magic-modules This repo is used to generate both the terraform-provider-google and terraform-provider-google-beta repository, keeping them in sync. Making changes there will also automatically generate the website file The data source itself could go here: https://github.com/GoogleCloudPlatform/magic-modules/tree/master/third_party/terraform/data_sources The markdown file would go here: https://github.com/GoogleCloudPlatform/magic-modules/tree/master/third_party/terraform/website/docs/d And you would make a similar change to https://github.com/GoogleCloudPlatform/magic-modules/blob/master/third_party/terraform/utils/provider.go.erb That should be it. I can also upstream this manually for you, but with newly added files it gets a bit tricky. Let me know if it is possible to make your PR aginst MM |
|
Done |
|
Closing in favor of GoogleCloudPlatform/magic-modules#3623 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
This PR was intended to add support for google redis instance data source