Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout on google_dataproc_metastore_service to 75m (from 60m) #20981

Conversation

modular-magician
Copy link
Collaborator

Related to #20978

The underlying operation appears to time out after an hour, but takes a few minutes to report. Since we time out after an hour, we'll never actually hit the failed operation and will time out ourselves in these cases. Add a 15m buffer for time from resource execution start in Terraform + service reporting failure through the LRO + LRO poll from Terraform and we should now pass through the service's underlying failure reason.

The change is still not very useful for debugging, but is still an improvement because it's something rather than a generic Terraform message (and will improve if the API ever sends more details): Error: Error waiting to create Service: Error waiting for Creating Service: timeout while waiting for state to become 'done: true' (last state: 'done: false', timeout: 1h0m0s) -> ~Error: Error waiting to create Service: Error waiting for Creating Service: Error code 4. Operation deadline exceeded.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

metastore: increased timeout on google_dataproc_metastore_service operations to 75m from 60m. This will expose server-returned reasons for operation failure instead of masking them with a Terraform timeout.

Derived from GoogleCloudPlatform/magic-modules#12824

…m) (hashicorp#12824)

[upstream:fde8ff16bbd30b654f1e10f2bba74d3b902fc5cc]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner January 21, 2025 21:01
@modular-magician modular-magician merged commit 49b9b0c into hashicorp:main Jan 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant