Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nodepool concurrent ops scale better #20738

Conversation

modular-magician
Copy link
Collaborator

The purpose of this change is to stagger operation creations, but still keeps operations concurrent, so that operations are not bottlenecked on creation and fail.
To achieve the above,

  • a cluster-scope lock is held for operation creation
  • cluster-scope lock is released after creation is done
  • cluster-scope read lock is held while waiting for operation to complete (as before)

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

container: make nodepool concurrent operations scale better

Derived from GoogleCloudPlatform/magic-modules#12488

Co-authored-by: Scott Suarez <[email protected]>

[upstream:1dbed42bb9ea904991e432c09a28fffca929452e]

Signed-off-by: Modular Magician <[email protected]>
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant