Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for deletion_policy on shared vpc service project #13822

Conversation

modular-magician
Copy link
Collaborator

Signed-off-by: NexusNull [email protected]

part of: #13699

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added field `deletion_policy` to resource `google_compute_shared_vpc_service_project`

Derived from GoogleCloudPlatform/magic-modules#7283

…ashicorp#7283)

* feat: Add support for deletion_policy on shared vpc service project

Signed-off-by: NexusNull <[email protected]>

* test: Add tests for deletion_policy on shared vpc service project

Signed-off-by: NexusNull <[email protected]>

* fix: reorder tests for better coverage

Signed-off-by: NexusNull <[email protected]>

* Update mmv1/third_party/terraform/resources/resource_compute_shared_vpc_service_project.go.erb

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* fix: add comma in test

Signed-off-by: NexusNull <[email protected]>

* fix formatting

Signed-off-by: NexusNull <[email protected]>

---------

Signed-off-by: NexusNull <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 984817b into hashicorp:main Feb 23, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2023
@modular-magician modular-magician deleted the downstream-pr-f9177e109f1cd459fd3e1f43432bf0cd970434d3 branch November 17, 2024 03:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant