Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update origin field to use self link or name #10181

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/5243.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:none

```
5 changes: 3 additions & 2 deletions google/resource_network_services_edge_cache_origin.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,9 @@ If a Cloud Storage bucket is provided, it must be in the canonical "gs://bucketn
Description: `A human-readable description of the resource.`,
},
"failover_origin": {
Type: schema.TypeString,
Optional: true,
Type: schema.TypeString,
Optional: true,
DiffSuppressFunc: compareResourceNames,
Description: `The Origin resource to try when the current origin cannot be reached.
After maxAttempts is reached, the configured failoverOrigin will be used to fulfil the request.

Expand Down
5 changes: 3 additions & 2 deletions google/resource_network_services_edge_cache_service.go
Original file line number Diff line number Diff line change
Expand Up @@ -341,8 +341,9 @@ Response headers are only sent to the client, and do not have an effect on the c
},
},
"origin": {
Type: schema.TypeString,
Optional: true,
Type: schema.TypeString,
Optional: true,
DiffSuppressFunc: compareSelfLinkOrResourceName,
Description: `The Origin resource that requests to this route should fetch from when a matching response is not in cache. Origins can be defined as short names ("my-origin") or fully-qualified resource URLs - e.g. "networkservices.googleapis.com/projects/my-project/global/edgecacheorigins/my-origin"

Only one of origin or urlRedirect can be set.`,
Expand Down