Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_billing_budget documentation is incorrect #9458

Open
adziura-tcloud opened this issue Jun 29, 2021 · 1 comment
Open

google_billing_budget documentation is incorrect #9458

adziura-tcloud opened this issue Jun 29, 2021 · 1 comment

Comments

@adziura-tcloud
Copy link

adziura-tcloud commented Jun 29, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

all_updates_rule are documented incorrectly.
Notifications are sent on every update only in case of pubsub_topic.
If you choose monitoring_notification_channels notifications are send based on configured thresholds.

Proposed change

  • all_updates_rule -
    (Optional)
    Defines additional notification rules. In case of pubsub_topic
    they are sent on every update to the
    billing account's spend, regardless of the thresholds defined
    using threshold rules.
    Structure is documented below.

Affected Resource

  • google_billing_budget
@fourstepper
Copy link

Maybe the name all_updates_rule is not necessarily correct and would also be nice to rename this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants