PubSub Schema evolution - when revision limit is reached, resource can't be updated

[uthark]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
• Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.
• If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Affected Resource(s)

• google_pubsub_schema

Terraform Configuration Files

# Copy-paste your Terraform configurations here.
#
# For large Terraform configs, please use a service like Dropbox and share a link to the ZIP file.
# For security, you can also encrypt the files using our GPG public key:
#    https://www.hashicorp.com/security
#
# If reproducing the bug involves modifying the config file (e.g., apply a config,
# change a value, apply the config again, see the bug), then please include both:
# * the version of the config before the change, and
# * the version of the config after the change.

Debug Output

Panic Output

Expected Behavior

Actual Behavior

Steps to Reproduce

1. Create schema and change it 20 times so that you get 20 revisions. 21st revision would fail.
2. terraform apply

Important Factoids

References

• #0000

b/294553291

[edwardmedia]

@uthark sounds like this is the restriction of the feature (api). Not sure how much the provider can do. Are you able to create more than 20 revisions via other means?

[uthark]

old revisions could be removed via API. O.

…

On Wed, Jul 19, 2023 at 12:45 PM Edward Sun ***@***.***> wrote: @uthark <https://github.com/uthark> sounds like this is the restriction of the feature (api). Not sure how much the provider can do. Are you able to create more than 20 revisions via other means? — Reply to this email directly, view it on GitHub <#15228 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABK75WHKQYRCGDQTO7L4KTXRA2L7ANCNFSM6AAAAAA2QLXQ5U> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[shuyama1]

Hey @melinath, I assume that you may have some context on this issue so I assign it to you. Apologize if I'm wrong and feel free to unassign yourself. (not forwarding this ticket to service team at this moment)

[melinath]

This is a constraint of the API - when pubsub schema updates were implemented, we had a lot of trouble deciding how Terraform should behave and ended up settling on this for now. We're definitely interested in hearing how folks would like to see this behave.

The best workaround in the meantime is to delete old revisions manually using gcloud or cloud console.

attn @kamalaboulhosn

[rileykarson]

Note: We may just want to describe how this works in the resource docs- the 20 revision limit, and the fact that users will need to manually clear revisions if they reach it.

[uthark]

wondering if it could be an additional flag to remove old revisions automatically. In the meantime we decided to implement additional pre-flight checks to verify if the limit is reached. O.

…

On Mon, Jul 31, 2023 at 9:50 AM Riley Karson ***@***.***> wrote: Note: We may just want to describe how this works in the resource docs- the 20 revision limit, and the fact that users will need to manually clear revisions if they reach it. — Reply to this email directly, view it on GitHub <#15228 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABK75TEXIRKTGBMO4HYQ5LXS7O3ZANCNFSM6AAAAAA2QLXQ5U> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.