Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TeamCity diff checker tool #8802

Conversation

modular-magician
Copy link
Collaborator

Description

This PR:

  • Adds testing to the TC diff checker
  • Refactors logic to add more user feedback and provide feedback about mismatches in both directions between TC config and provider code
  • Changes how the tool is invoked from GHAs

Context

TeamCity diff checker has been failing for a few weeks:

Screenshot 2024-11-25 at 15 50 55

Here is an example:
Screenshot 2024-11-25 at 15 51 54

This error is confusing because:

However:

With better user feedback this could be less confusing


Derived from GoogleCloudPlatform/magic-modules#12426

[upstream:a854242eeddd1d0aa08895352d50015ef70c24fa]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner November 27, 2024 23:25
@modular-magician modular-magician merged commit 599a04f into hashicorp:main Nov 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant