container: fix node_config.kubelet_config updates in google_container_cluster
#8238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ner_cluster` (#11697) [upstream:846050f21990e35de9b679c9dcac493204a02013] Signed-off-by: Modular Magician <[email protected]>
modular-magician
deleted the
downstream-pr-846050f21990e35de9b679c9dcac493204a02013
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still shy of a fix for updates for everything within
node_config, and doesn't consolidate where we're updating thegoogle_container_node_poolresource vs. thedefault-poolthat can be created directly withingoogle_container_cluster, but it does fix a subset of the fields that don't work, and also simplifies some of the code and consolidates some tests, so maybe still worth considering as another step in the right direction.node_config.kubelet_configwhere updates didn't function properly (basically all except forinsecure_kubelet_readonly_port_enabled.node_config.kubelet_configwith the one fornode_config.kubelet_config.insecure_kubelet_readonly_port_enabled, including testing updates.Part of hashicorp/terraform-provider-google#19225
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#11697