Add support for regional secret version resource google_secret_manager_regional_secret_version
#8199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er_regional_secret_version` (#11699) [upstream:2a9c7e6ce823646f03bbf4a42b8825c7e6166cf7] Signed-off-by: Modular Magician <[email protected]>
modular-magician
deleted the
downstream-pr-2a9c7e6ce823646f03bbf4a42b8825c7e6166cf7
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for new regional secret version resource
google_secret_manager_regional_secret_version.More info about regional secrets: https://cloud.google.com/secret-manager/docs/regional-secrets-overview
A point to be noted is that while importing the
google_secret_manager_regional_secret_versionresources having theis_secret_data_base64field set to true, thesecret_datais decoded from the base64-encoded string received from API. It is potentially due to condition in the flattener for payload (which is in place for the sake ofis_secret_data_base64field to work). It seems the import is working fine when theis_secret_data_base64is not provided or set to false. While doing a terraform import, there is no way to determine if the resource to be imported requires decoding of base64 response.References: hashicorp/terraform-provider-google#10129 & GoogleCloudPlatform/magic-modules#8873
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#11699