container: make cpu_manager_policy optional in kubelet_config
#8171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1572) Co-authored-by: Stephen Lewis (Burrows) <[email protected]> [upstream:c920b8fc0cd06c1450c7da57434418b1fa307ebc] Signed-off-by: Modular Magician <[email protected]>
modular-magician
deleted the
downstream-pr-c920b8fc0cd06c1450c7da57434418b1fa307ebc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of hashicorp/terraform-provider-google#19225
This should resolve some confusing behavior with
cpu_manager_policy"") seems to work.GoogleCloudPlatform/magic-modules@efb71a9#r458238583
GoogleCloudPlatform/magic-modules@efb71a9#r473173480
☝️ context on when it was originally marked
RequiredThis doesn't resolve all of the issues, but resolves other issues where it must be set where it's not actually needed (for example, if
insecure_kubelet_readonly_port_enabledis set).It appears that it was marked as
Requiredsomewhat arbitrarily (see above), and it's also possible that some of what's in place is tied to an API level bug that may have since been resolved. Maybe we could require at last one instead -- happy to do that if there's a good example to follow.I did come across hashicorp/terraform-provider-google#15767 while testing this, but I think this is neutral as far as that goes.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#11572