Validate that subnetwork_project should match with the project in subnetwork field in google_compute_instance resource
#8089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…subnetwork` field in `google_compute_instance` resource (#11537) [upstream:a4183752c8464e20aa4055ed0b0520f309a09904] Signed-off-by: Modular Magician <[email protected]>
modular-magician
deleted the
downstream-pr-a4183752c8464e20aa4055ed0b0520f309a09904
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes hashicorp/terraform-provider-google#15749
The
subnetwork_projectfield is ignored in the API request when a self_link is given insubnetwork, but not in terraform which is correct behavior becausesubnetwork_projectis still in the code. Suppressing a diff on this seems unreasonable because providing something like this isn't really a valid configMaybe throw an error when this happens?
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#11537