Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix condition in forceNewIfNetworkIPNotUpdatableFunc #7971

Conversation

modular-magician
Copy link
Collaborator

Resolves issue #16494

This function didn't work before.

d.HasChange will always return true in this condition because of this comparasion on the network field

https://www.googleapis.com/compute/v1/projects/iac-poc-krakow/global/networks/default
against
default

Release Note Template for Downstream PRs (will be copied)

compute: fixed force diff replacement logic for `network_ip` on resource `google_compute_instance`

Derived from GoogleCloudPlatform/magic-modules#11395

[upstream:8400c36d049b635bd63e1a79ae9229fa8c304c5c]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit e88cfd7 into hashicorp:main Aug 14, 2024
4 checks passed
@modular-magician modular-magician deleted the downstream-pr-8400c36d049b635bd63e1a79ae9229fa8c304c5c branch November 16, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_compute_instance update network_interface.network_ip with google_compute_address
1 participant