Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retaining unchanged alias ip ranges and handle permadiff caused by the change #7898

Conversation

modular-magician
Copy link
Collaborator

References issue #12286

  • added checkForCommonAliasIp() function and condition to use it
  • Added tests for this scenario
  • Maintaining the unchanged ranges causes permadiff because of sorting so flattening function needed to be rewritten

Release Note Template for Downstream PRs (will be copied)

compute: fixed maintaining unchanged `alias_ip_range` in `compute_instance` in between PATCH API calls and handled permadiff caused by the change

Derived from GoogleCloudPlatform/magic-modules#11321

…y the change (#11321)

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

[upstream:8fbe154440c88dc24388746f2a1cd48929a293a3]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit a7062da into hashicorp:main Aug 6, 2024
4 checks passed
@modular-magician modular-magician deleted the downstream-pr-8fbe154440c88dc24388746f2a1cd48929a293a3 branch November 16, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant