Add validation to prevent BigQuery view from creation when input schema contains required fields #7755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ma contains required fields (#11101) [upstream:1d43e02fe8cbee792dc721792a3ed7dd3cfdde67] Signed-off-by: Modular Magician <[email protected]>
modular-magician
merged commit c1cdf12
into
hashicorp:FEATURE-BRANCH-major-release-6.0.0
3 checks passed
modular-magician
deleted the
downstream-pr-1d43e02fe8cbee792dc721792a3ed7dd3cfdde67
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes hashicorp/terraform-provider-google#14220.
Old behavior: Create API is called to first create the view without schema, then Update API is called to apply the schema to the view, at which point it will result in an error if the schema contains any required fields. The new table is left created with fields being nullable. Subsequent
applywill result in permadiff.New behavior: No new table is created if view is specified while schema contains required fields.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#11101