Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom domain configuration for Looker #6979

Conversation

modular-magician
Copy link
Collaborator

Fixes: hashicorp/terraform-provider-google#17193

Release Note Template for Downstream PRs (will be copied)

looker: added `custom_domain` field to `google_looker_instance ` resource

Derived from GoogleCloudPlatform/magic-modules#9936

* Add custom domain configuration for Looker

* Add test case

* Fix test

* Add small change in test to include domain

* Simplify domain state output

[upstream:04ddc21dd5f7cb400b14a5746042c6d0dfeea889]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 28b9f4c into hashicorp:main Feb 16, 2024
4 checks passed
@modular-magician modular-magician deleted the downstream-pr-04ddc21dd5f7cb400b14a5746042c6d0dfeea889 branch November 16, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Looker-instance: add possibility to add the custom-domain to a looker instance (optional argument)
1 participant