Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestAccEventarcGoogleChannelConfig_cryptoKeyUpdate to properly clean up #5339

Conversation

modular-magician
Copy link
Collaborator

fixes hashicorp/terraform-provider-google#12908

After making updates to the way we manage permissions during tests, we still saw issues with a few TestAccCloudfunctions2function* tests. It turns out TestAccEventarcGoogleChannelConfig_cryptoKeyUpdate was leaving a region-wide configuration on the project that enforced CMEK on all eventarc channels, which were being used in these cloudfunction tests. See https://cloud.google.com/eventarc/docs/use-cmek.

To fix our tests, I've updated TestAccEventarcGoogleChannelConfig_cryptoKeyUpdate to clean up its region-wide CMEK when it is finished. Note that this apparently does not happen automatically on destroy, which is why I needed an additional step to clear the config with an update.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#7479

@modular-magician modular-magician merged commit bb3fbc5 into hashicorp:main Mar 17, 2023
@modular-magician modular-magician deleted the downstream-pr-441886964febfd4bfc4465dd7ff80ecbe0c52310 branch November 16, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): gcp-sa-pubsub.iam.gserviceaccount.com CryptoKey Encrypter/Decrypter role
1 participant