Fix TestAccEventarcGoogleChannelConfig_cryptoKeyUpdate to properly clean up #5339
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes hashicorp/terraform-provider-google#12908
After making updates to the way we manage permissions during tests, we still saw issues with a few
TestAccCloudfunctions2function*
tests. It turns outTestAccEventarcGoogleChannelConfig_cryptoKeyUpdate
was leaving a region-wide configuration on the project that enforced CMEK on all eventarc channels, which were being used in these cloudfunction tests. See https://cloud.google.com/eventarc/docs/use-cmek.To fix our tests, I've updated
TestAccEventarcGoogleChannelConfig_cryptoKeyUpdate
to clean up its region-wide CMEK when it is finished. Note that this apparently does not happen automatically on destroy, which is why I needed an additional step to clear the config with an update.If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#7479