Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds grpc field to liveness_probe and startup_probe to google_cloud_run_v2_service resource #5259

Conversation

modular-magician
Copy link
Collaborator

This PR adds gRPC probes options for Cloud Run v2 Service resources.

The grpc fields in startup_probe and liveness_probe in the google_cloud_run_service (v1) resource were added by #6781.
The support for Cloud Run v2 Services was introduced by #6850 and released in terraform-google-provider 4.46.0, but the gRPC options for liveness probe and startup probe for the v2 services are missing.

The Go SDK v0.102.0, which this project currently uses, does not yet support the gRPC probe options for Cloud Run v2 Services. The SDK needs to be upgraded to at least v0.104.0.
So this PR waits for #6962 to be merged.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

added `template.0.containers0.liveness_probe.grpc`, `template.0.containers0.startup_probe.grpc` fields to `google_cloud_run_v2_service` resource

Derived from GoogleCloudPlatform/magic-modules#6987

…cloud_run_v2_service` resource (hashicorp#6987)

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit ff75441 into hashicorp:main Feb 27, 2023
@modular-magician modular-magician deleted the downstream-pr-e2918f187f905d88a906b71ece64f61aafd1cdb0 branch November 16, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant