Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove validation for the IP protocol type #4496

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Remove validation for the IP protocol type #4496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/6271.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:enhancement
Remove validation for the IP protocol type
```
5 changes: 2 additions & 3 deletions google-beta/resource_compute_packet_mirroring.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,10 +169,9 @@ destination (egress) IP in the IP header. Only IPv4 is supported.`,
"ip_protocols": {
Type: schema.TypeList,
Optional: true,
Description: `Protocols that apply as a filter on mirrored traffic. Possible values: ["tcp", "udp", "icmp"]`,
Description: `Possible IP protocols including tcp, udp, icmp and esp`,
Elem: &schema.Schema{
Type: schema.TypeString,
ValidateFunc: validateEnum([]string{"tcp", "udp", "icmp"}),
Type: schema.TypeString,
},
},
},
Expand Down
3 changes: 1 addition & 2 deletions website/docs/r/compute_packet_mirroring.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,7 @@ The following arguments are supported:

* `ip_protocols` -
(Optional)
Protocols that apply as a filter on mirrored traffic.
Each value may be one of `tcp`, `udp`, and `icmp`.
Possible IP protocols including tcp, udp, icmp and esp

* `cidr_ranges` -
(Optional)
Expand Down